Re: [PATCH 4/5] uio: Support 2^MINOR_BITS minors

From: Thomas Gleixner
Date: Tue Sep 21 2010 - 18:26:34 EST


On Tue, 21 Sep 2010, Eric W. Biederman wrote:
> Thomas Gleixner <tglx@xxxxxxxxxxxxx> writes:
> The compiler will make this transformation on it's own when it compiles
> the code, because it does result in slightly better code.

I doubt the compiler part, but I'm not religious about that. It's a
question of personal preference.

> *shrug* In the grand scheme of things it isn't a big deal.
>
> I'm much more interested in getting the uio driver hotplug safe so when
> I physically remove a device I am using I don't get a kernel crash.

No objections.

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/