Re: [PATCH] x86/mrst: add SFI platform device parsing code

[Mark Brown]

On Thu, Sep 23, 2010 at 11:58:18AM +0100, Alan Cox wrote:
> Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:

> > So what is the plan for coping with OEM systems?  Right now the code
> > makes no provision at all that I can see for system-specific handling
> > of the SFI data which seems very optimistic.

> There are various system specific drivers which have their own sfi entry
> and name. Telling platforms apart is a problem with SFI but the latest
> firmware also supports DMI so we can get platform identification via the
> normal PC interfaces.

So the expectation is that the platform data parser functions in the SFI
device list will be querying the DMI data and selecting the actual
parsing based on that?  Perhaps adding DMI keys to the match tables so
the infrastructure is there for doing the device specific things would
cover it; minor differences could be worked out in the default match
function and we can drop back to board specific functions when it gets
too messy.

My main issue here is that the code is working on the assumption that we
have one standard idea of what the SFI data means and provides no
guidance to users about handling the inevitable variations.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/