Re: [PATCH] ds2760_battery: add HAS_IOMEM dependency

[Anton Vorontsov]

On Thu, Sep 23, 2010 at 12:44:45PM +0200, Martin Schwidefsky wrote:
> From: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> 
> Fix this Kconfig warning on allmodconfig for s390:
> 
> warning: (BATTERY_DS2760 && POWER_SUPPLY) selects W1 which has unmet direct dependencies (HAS_IOMEM)
> 
> Cc: Anton Vorontsov <cbou@xxxxxxx>
> Signed-off-by: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> ---
> 
>  drivers/power/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff -urpN linux-2.6/drivers/power/Kconfig linux-2.6-patched/drivers/power/Kconfig
> --- linux-2.6/drivers/power/Kconfig	2010-09-23 08:47:36.000000000 +0200
> +++ linux-2.6-patched/drivers/power/Kconfig	2010-09-23 08:47:39.000000000 +0200
> @@ -64,6 +64,7 @@ config TEST_POWER
>  
>  config BATTERY_DS2760
>  	tristate "DS2760 battery driver (HP iPAQ & others)"
> +	depends on HAS_IOMEM
>  	select W1
>  	select W1_SLAVE_DS2760

I think the better fix would be to turn this into 'depends on W1',
and remove these selects.

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@xxxxxxxxx
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/