Re: [PATCH] kmemleak: add unlikely() optimization tokmemleak_late_init

[Davidlohr Bueso]

On Wed, 2010-09-22 at 11:06 +0100, Catalin Marinas wrote:
> Davidlohr Bueso <dave@xxxxxxx> wrote:
> > kmemleak: add unlikely() optimization to kmemleak_late_init()
> >
> > Since there it is not very probable that kmemleak_disable() was called right after setting kmemleak_initialized, we could benefit from predicting it.
> 
> The patch is correct and you can add my Acked-by but I don't really
> think it's worth. We save ~2 cycles during booting, no-one would ever
> notice.
> 

Yeah, it's not a big performance booster, but IMHO it wouldn't hurt to
add it. Since you are the maintainer it's up to you if you include it
upstream.

Thanks,
Davidlohr

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/