Re: [PATCH] DMAENGINE: make sure we can always define platform data

[Dan Williams]

On Fri, Sep 10, 2010 at 3:13 AM, Linus Walleij
<linus.walleij@xxxxxxxxxxxxxx> wrote:
> If you try to compile platform data structs for the PL08X without
> it being compiled in, symbol resoltion will fail on the filter
> function when linking the kernel, so provide a dummy function.
>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>
> ---
> Dan, this goes on top of the other stuff queued on top of the
> PL08X driver merged for next. Feel free to squash this too if
> you prefer.
> ---
>  include/linux/amba/pl08x.h |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/amba/pl08x.h b/include/linux/amba/pl08x.h
> index 8435f4a..daee6d0 100644
> --- a/include/linux/amba/pl08x.h
> +++ b/include/linux/amba/pl08x.h
> @@ -179,6 +179,13 @@ struct pl08x_platform_data {
>        void (*put_signal)(struct pl08x_dma_chan *);
>  };
>
> +#ifdef CONFIG_AMBA_PL08X
>  bool pl08x_filter_id(struct dma_chan *chan, void *chan_id);
> +#else
> +static bool pl08x_filter_id(struct dma_chan *chan, void *chan_id)

Missing "inline"?

You can include this when you respin the driver for the prep vs submit rework.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/