Re: checkpatch problem

From: Joe Perches
Date: Thu Sep 23 2010 - 16:31:09 EST


On Thu, 2010-09-23 at 19:54 +0100, David Howells wrote:
> Joe Perches <joe@xxxxxxxxxxx> wrote:
> > Exactly right. Andy has a version in his testing directory
> > that fixes this #define run-on block and speeds up checkpatch
> > runtime rather a lot for certain files like .h files that have
> > nothing but #defines.
> > Try applying my patch to this newer version:
> > http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing
>
> It still doesn't work. In fact, I'm seeing more "Logging function has
> unnecessary whitespace before a newline" warnings, such as on this:
>
> printk(KERN_ERR
> "BUG: CPU#%d started up but did not get a callout!\n",
> cpu);

Yes, it's completely borked.

ctx_statement_block returns code beyond the current
statement terminating ";".

Andy may be able to do something about it or know
about some appropriate knob to twist.

I don't really want to learn too much about
checkpatch internals. Sorry.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/