Re: fs hang in 2.6.27.y | Fwd: [Bug 15658] New: [PATCH] x86 constant_test_bit() prone to misoptimization with gcc-4.4

From: Michael Shigorin
Date: Fri Sep 24 2010 - 03:05:25 EST


On Thu, Sep 23, 2010 at 04:50:22PM -0700, Andrew Morton wrote:
> (huge quote)

Andrew, huge THANKS for getting to this!

> Working around a gcc-4.4 bug is a good thing, and the patch
> cleans the code up anyway - is there a reason for casting away
> the `volatile const'?

We'll discuss this; I'm actually no kernel developer (a silly
local iso9660 patch in 1999, nothing more) but rather a proxy.

> We don't have a Signed-off-by: for this patch - it would be
> good to have one, please. We should at least have yours, as
> you sent the patch.

OK, Greg already told us to do so for stable@ but things were
busy there as well. We'll fix up.

> Also, we prefer to have real names in kernel commits.
> Does "Led" refer to Alexander Chumachenko?

Yes.

2 led: a signed-off patch, please? :)

--
---- WBR, Michael Shigorin <mike@xxxxxxxxxxx>
------ Linux.Kiev http://www.linux.kiev.ua/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/