Re: [PATCH RESEND] signal: annotate siglock acquisition

[Namhyung Kim]

On Sat, Sep 25, 2010 at 12:26, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> On Sat, Sep 25, 2010 at 12:20:56PM +0900, Namhyung Kim wrote:
>> lock_task_sighand() conditionally acquires sighand->siglock in case of
>> returning non-NULL but unlock_task_sighand() releases it unconditionally.
>> This leads sparse to complain about the lock context imbalance. Annotate it
>> to make sparse happier.
>
> That's not a good way to do it; use __cond_lock instead.
>

Thanks. I'll resend a patch that uses it.


-- 
Regards,
Namhyung Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/