[PATCH] misc: phantom: Added missing warning messages in phantom_probe

From: Rahul Ruikar
Date: Sat Sep 25 2010 - 09:51:30 EST


phantom_probe can fail at many places. missing warning messages
have been added for 2 cases.
pci_enable_device()
pci_request_regions()

Signed-off-by: Rahul Ruikar <rahul.ruikar@xxxxxxxxx>
---
drivers/misc/phantom.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/phantom.c b/drivers/misc/phantom.c
index 75ee0d3..b4c105f 100644
--- a/drivers/misc/phantom.c
+++ b/drivers/misc/phantom.c
@@ -341,8 +341,10 @@ static int __devinit phantom_probe(struct pci_dev *pdev,
int retval;

retval = pci_enable_device(pdev);
- if (retval)
+ if (retval) {
+ dev_err(&pdev->dev, "pci_enable_device failed!\n");
goto err;
+ }

minor = phantom_get_free();
if (minor == PHANTOM_MAX_MINORS) {
@@ -354,8 +356,10 @@ static int __devinit phantom_probe(struct pci_dev *pdev,
phantom_devices[minor] = 1;

retval = pci_request_regions(pdev, "phantom");
- if (retval)
+ if (retval) {
+ dev_err(&pdev->dev, "pci_request_regions failed!\n");
goto err_null;
+ }

retval = -ENOMEM;
pht = kzalloc(sizeof(*pht), GFP_KERNEL);
--
1.7.2.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/