Re: [PATCHv3 1/3] watchdog: add f71862fg support

[Giel van Schijndel]

On Sun, Sep 26, 2010 at 04:25:35PM +0200, Lutz Ballaschke wrote:
> Watchdog support for Fintek F71862fg Super-I/O added.
> Two different hardware reset pins of the F71862fg chip can be configured 
> by an additional module parameter.
> 
> Signed-off-by: Lutz Ballaschke <vegan.grindcore@xxxxxxxxxxxxxx>
> ---
> 
>  drivers/watchdog/f71808e_wdt.c |   44 ++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 44 insertions(+), 0 deletions(-)
> 
> 
> diff --git a/drivers/watchdog/f71808e_wdt.c b/drivers/watchdog/f71808e_wdt.c
> index 7e5c266..546cef6 100644
> --- a/drivers/watchdog/f71808e_wdt.c
> +++ b/drivers/watchdog/f71808e_wdt.c
> @@ -282,6 +295,28 @@ exit_unlock:
>  	return err;
>  }
>  
> +static int f71862fg_pin_configure(unsigned short ioaddr)
> +{
> +	/* When ioaddr is non-zero the calling function has to take care of
> +	   mutex handling and superio preparation! */
> +

Given that this basically documents how the function should be used
(i.e. API documentation) you might want to put the comment block
*before* the function's prototype.  You could use kernel-doc for it if
you wish (Documentation/kernel-doc-nano-HOWTO.txt).

This is just advice though, so:

Signed-off-by: Giel van Schijndel <me@xxxxxxxxx>

-- 
Met vriendelijke groet,
With kind regards,
Giel van Schijndel
--
"There are two major products that come out of Berkeley: LSD and UNIX.
 We don't believe this to be a coincidence."
  -- Jeremy S. Anderson

Attachment: signature.asc
Description: Digital signature