Re: [PATCH 1/2] namespace.pl: fix source tree name mangling

[AmÃrico Wang]

On Tue, Sep 28, 2010 at 05:44:02PM +0900, Stephen Hemminger wrote:
>The current namespace.pl script does not find source files correctly.
>The problem is that the current directory is not the base of the kernel
>tree at the point where it calls objdump.
>
>Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxxxx>
>
>--- a/scripts/namespace.pl	2010-09-27 17:53:29.919433444 +0900
>+++ b/scripts/namespace.pl	2010-09-28 09:24:36.891552993 +0900
>@@ -167,8 +167,10 @@ sub do_nm
> 		printf STDERR "$fullname is not an object file\n";
> 		return;
> 	}
>-	($source = $fullname) =~ s/\.o$//;
>-	if (-e "$objtree$source.c" || -e "$objtree$source.S") {
>+	$fullname =~ s/\.o$//;
>+	$source = $basename;
>+	$source =~ s/\.o$//;

With your patch applied, $source will be the basename of
an obj path with .o stripped.

>+	if (-e "$objtree$fullname.c" || -e "$objtree$fullname.S") {
> 		$source = "$objtree$source";
> 	} else {
> 		$source = "$srctree$source";
>

So here we will get a non-exist path stored in $source.

Are you serious? What problem did you meet? I see no problem
with the original code here.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/