RE: [PATCH] mrst_max3110: Missing linux/irq.h include.

From: Tang, Feng
Date: Wed Sep 29 2010 - 14:44:12 EST


Looks good to me, thanks for fixing it.

- Feng
-----Original Message-----
From: David Miller [mailto:davem@xxxxxxxxxxxxx]
Sent: Tuesday, September 28, 2010 11:36 PM
To: gregkh@xxxxxxx
Cc: Tang, Feng; linux-kernel@xxxxxxxxxxxxxxx
Subject: [PATCH] mrst_max3110: Missing linux/irq.h include.


This driver makes use of IRQ_TYPE_EDGE_FALLING, therefore it must
include linux/irq.h

drivers/serial/mrst_max3110.c: In function 'serial_m3110_startup':
drivers/serial/mrst_max3110.c:470:5: error: 'IRQ_TYPE_EDGE_FALLING' undeclared (first use in this function)
drivers/serial/mrst_max3110.c:470:5: note: each undeclared identifier is reported only once for each function it appears in

Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>

diff --git a/drivers/serial/mrst_max3110.c b/drivers/serial/mrst_max3110.c
index f6ad1ec..915dedc 100644
--- a/drivers/serial/mrst_max3110.c
+++ b/drivers/serial/mrst_max3110.c
@@ -33,6 +33,7 @@
#include <linux/console.h>
#include <linux/sysrq.h>
#include <linux/platform_device.h>
+#include <linux/irq.h>
#include <linux/tty.h>
#include <linux/tty_flip.h>
#include <linux/serial_core.h>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/