Re: [Patch 1/3] Introduce kset_find_obj_hinted.

[Robin Holt]

On Wed, Sep 29, 2010 at 01:59:16PM -0700, Dave Hansen wrote:
> On Wed, 2010-09-29 at 14:00 -0500, Robin Holt wrote:
> > 
> >  struct kobject *kset_find_obj(struct kset *kset, const char *name)
> >  {
> > +       return kset_find_obj_hinted(kset, name, NULL);
> > +}
> > +
> > +/**
> > + * kset_find_obj_hinted - search for object in kset given a predecessor hint.
> > + * @kset: kset we're looking in.
> > + * @name: object's name.
> > + * @hint: hint to possible object's predecessor.
> > + *
> > + * Check the hint's next object and if it is a match return it directly,
> > + * otherwise, fall back to the behavior of kset_find_obj().  Either way
> > + * a reference for the returned object is held and the reference on the
> > + * hinted object is released.
> > + */
> > +struct kobject *kset_find_obj_hinted(struct kset *kset, const char *name,
> > +                                    struct kobject *hint)
> > +{
> >         struct kobject *k;
> >         struct kobject *ret = NULL;
> > 
> >         spin_lock(&kset->list_lock);
> > +
> > +       if (!hint)
> > +               goto slow_search;
> > +
> > +       /* end of list detection */
> > +       if (hint->entry.next == kset->list.next)
> > +               goto slow_search;
> > +
> > +       k = container_of(hint->entry.next, struct kobject, entry);
> > +       if (!kobject_name(k) || strcmp(kobject_name(k), name))
> > +               goto slow_search;
> > +
> > +       ret = kobject_get(k);
> > +       goto unlock_exit;
> > +
> > +slow_search:
> >         list_for_each_entry(k, &kset->list, entry) {
> >                 if (kobject_name(k) && !strcmp(kobject_name(k), name)) {
> >                         ret = kobject_get(k);
> >                         break;
> >                 }
> >         }
> 
> So, the slow search ends up looking through _all_ of the sections in the
> order they got registered, which _guarantees_ that we'll go all the way
> through the list every time.  Right?
> 
> I guess we could also add to the list using list_add_tail(), iterate
> during the search using list_for_each_tail(), or even just look at the
> last entry by looking at kset->list.prev directly.  Those would have the
> advantage of not having to have several levels in the call chain.  We
> also wouldn't have to change anything if and when this gets fixed
> properly.

Except that drivers/base/memory.c's memory_dev_init registers all the
memory sections and then later, drivers/base/node.c's node_dev_init
looks for memory sections on each node and does the symlink.

Since the two are separated in time, either the head or tail based search
is going to end up with last or first part of the search sequence being
much slower.

Robin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/