Re: [PATCH 3/4] cs5535: add some additional cs5535-specific GPIOfunctionality

From: Greg KH
Date: Wed Sep 29 2010 - 21:45:16 EST


On Sat, Sep 25, 2010 at 07:07:12PM -0700, Andres Salomon wrote:
>
> This adds (well, re-adds actually) handling for events/IRQs through cs5535
> GPIOs. In the wild and wooly world of CS5535, setup_event() is for
> assigning an IRQ to a GPIO filter/event pair, and set_irq() sets up
> the pair to trigger IRQs.
>
> These should really only be used in highly platform-specific drivers (such
> as OLPC's DCON driver). Sadly, because set_irq() uses MSRs, this causes the
> driver to become X86-specific.
>
> Signed-off-by: Andres Salomon <dilinger@xxxxxxxxxx>
> ---
> drivers/gpio/Kconfig | 2 +-
> drivers/gpio/cs5535-gpio.c | 52 ++++++++++++++++++++++++++++++++++++++++++++
> include/linux/cs5535.h | 2 +

I can't take this change without the gpio subsystem maintainer acking
it. Can you get that approval from them?

I'm guessing that your 4/4 patch here depends on it, right? If so, I'll
hold off on applying that patch until we can figure out how to handle
this, ok?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/