Re: [PATCH 01/17] kernel: add bl_list

[Andrew Morton]

On Wed, 29 Sep 2010 22:18:33 +1000 Dave Chinner <david@xxxxxxxxxxxxx> wrote:

> From: Nick Piggin <npiggin@xxxxxxx>
> 
> Introduce a type of hlist that can support the use of the lowest bit
> in the hlist_head. This will be subsequently used to implement
> per-bucket bit spinlock for inode hashes.
> 
>
> ...
>
> +static inline void INIT_HLIST_BL_NODE(struct hlist_bl_node *h)
> +{
> +	h->next = NULL;
> +	h->pprev = NULL;
> +}

No need to shout.

>
> ...
>
> +static inline void hlist_bl_del(struct hlist_bl_node *n)
> +{
> +	__hlist_bl_del(n);
> +	n->next = LIST_POISON1;
> +	n->pprev = LIST_POISON2;
> +}

I'd suggest creating new poison values for hlist_bl's, leave
LIST_POISON1 and LIST_POISON2 for list_head (and any other list
variants which went and used them :()

>
> ...
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/