Re: [PATCH 05/17] fs: icache lock i_count

From: Andrew Morton
Date: Thu Sep 30 2010 - 00:51:32 EST


On Wed, 29 Sep 2010 22:18:37 +1000 Dave Chinner <david@xxxxxxxxxxxxx> wrote:

> - if (atomic_read(&inode->i_count) != 1)
> + if (inode->i_count != 1)

This really should have been renamed to catch unconverted code.

Such code usually wouldn't compile anyway, but it will if it takes the
address of i_count only (for example).

And maybe we should access this guy via accessor functions, dunno.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/