Re: [PATCH] Skip looking for ioapic overrides when ioapics are notpresent

From: H. Peter Anvin
Date: Thu Sep 30 2010 - 18:56:56 EST


On 06/05/2010 08:56 PM, Eric W. Biederman wrote:
>
> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
> index 33f3563..226a6d1 100644
> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c
> @@ -4066,6 +4066,9 @@ int acpi_get_override_irq(u32 gsi, int *trigger, int *polarity)
> {
> int ioapic, pin, idx;
>
> + if (acpi_irq_model != ACPI_IRQ_MODEL_IOAPIC)
> + return -1;
> +
> if (skip_ioapic_setup)
> return -1;
>

I was just poked about this patch... it doesn't build "make allnoconfig"
on x86-64.

This is also a bugzilla ticket now:
https://bugzilla.kernel.org/show_bug.cgi?id=17772

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/