Re: Regression (ancient), bisected: TCP hangs with certain ESP6 SA.

[Herbert Xu]

On Thu, Sep 30, 2010 at 06:17:16PM -0700, David Miller wrote:
> From: Nick Bowler <nbowler@xxxxxxxxxxxxxxxx>
> Date: Wed, 29 Sep 2010 10:22:13 -0400
> 
> > b5c15fc004ac83b7ad280acbe0fd4bbed7e2c8d4 is the first bad commit
> > commit b5c15fc004ac83b7ad280acbe0fd4bbed7e2c8d4
> > Author: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> > Date:   Thu Feb 14 23:49:37 2008 -0800
> > 
> >     [IPV6]: Fix reversed local_df test in ip6_fragment
> >     
> >     I managed to reverse the local_df test when forward-porting this
> >     patch so it actually makes things worse by never fragmenting at
> >     all.
> >     
> >     Thanks to David Stevens for testing and reporting this bug.
> >     
> >     Bill Fink pointed out that the local_df setting is also the wrong
> >     way around.
> >     
> >     Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> >     Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
> 
> I suspect that Herbert's change is correct, it's just that for some
> reason PMTU doesn't work correctly with IPV6 for whatever reason.
> 
> That matches with your observed behavior that ping and UDP stuff
> works just fine, and it's just TCP with certain ESP6 transport mode
> settings.

Yeah I suspect if you go back even further (before the patch with
the reversed logic referred to above) that you'll find it to be
broken again.

I'll try to reproduce this but I may not be able to get to it until
November.

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/