[PATCH] jbd: Use printk_ratelimit() in journal_alloc_journal_head()

From: Namhyung Kim
Date: Mon Oct 04 2010 - 05:17:23 EST


Use printk_ratelimit() instead of doing it manually.

Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxx>
---
fs/jbd/journal.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
index 6f20a75..d66dd36 100644
--- a/fs/jbd/journal.c
+++ b/fs/jbd/journal.c
@@ -1718,7 +1718,6 @@ static void journal_destroy_journal_head_cache(void)
static struct journal_head *journal_alloc_journal_head(void)
{
struct journal_head *ret;
- static unsigned long last_warning;

#ifdef CONFIG_JBD_DEBUG
atomic_inc(&nr_journal_heads);
@@ -1726,11 +1725,10 @@ static struct journal_head *journal_alloc_journal_head(void)
ret = kmem_cache_alloc(journal_head_cache, GFP_NOFS);
if (ret == NULL) {
jbd_debug(1, "out of memory for journal_head\n");
- if (time_after(jiffies, last_warning + 5*HZ)) {
+ if (printk_ratelimit())
printk(KERN_NOTICE "ENOMEM in %s, retrying.\n",
__func__);
- last_warning = jiffies;
- }
+
while (ret == NULL) {
yield();
ret = kmem_cache_alloc(journal_head_cache, GFP_NOFS);
--
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/