Re: [PATCH 1/1] omap: Ptr "isr_reg" tracked as NULL wasdereferenced

From: Felipe Balbi
Date: Tue Oct 05 2010 - 05:32:31 EST


Hi,

On Tue, Oct 05, 2010 at 03:42:10AM -0500, Evgeny Kuznetsov wrote:
+ if (!isr_reg) {
+ printk(KERN_ERR "FATAL: Incorrect GPIO method %i\n",
+ bank->method);
+ BUG();
+ }

this could be simply:

BUG_ON(!isr_reg);

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/