Re: [tip:x86/cpu] x86, cpu: Fix X86_FEATURE_NOPL

From: Borislav Petkov
Date: Tue Oct 05 2010 - 12:54:06 EST


From: "H. Peter Anvin" <hpa@xxxxxxxxxxxxxxx>
Date: Tue, Oct 05, 2010 at 09:30:37AM -0700

> On 10/5/2010 2:47 AM, Borislav Petkov wrote:
> >
> >tag it for -stable too?
> >
>
> What is the flaw that justifies it for stable, or even .36? It
> seems relatively harmless, with at most a very minor performance
> issue, unless I'm missing something?

I was thinking more along the lines of this being partially broken
when supplying non-constant arguments to cpu_has(), something like
<arch/x86/kernel/cpu/proc.c:show_cpuinfo()>, for example. But all this
could cause is /proc/cpuinfo not to report the "nopl" feature bit. I
guess this is too minor an issue to even to be considered for stable.

--
Regards/Gruss,
Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/