Re: [PATCH] scripts/checkpatch.pl: Warn on non-executable filescreated with non 100644 file permissions

[Rabin Vincent]

On Thu, Oct 7, 2010 at 5:01 AM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> +               if ($rawline =~ /^ create mode (\d+) ([\w\.\/\-]+)$/) {
> +                       my $mode = $1;
> +                       my $file = $2;
> +                       if ($mode ne "100644" && !($file =~ /\.(sh|pl|py|awk)$/)) {
> +                               WARN("FILE '$file' should probably use file permission 100644 not $mode\n" . $herecurr);
> +                       }
> +               }
> +

There's a vaguely similar patch already in -mm.  That one also handles mode
changes and doesn't require the presence of the diff summary.  Have a look in
case you missed it, maybe it does most of what you want and you can base
something on that:

http://userweb.kernel.org/~akpm/mmotm/broken-out/checkpatch-check-for-incorrect-permissions.patch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/