Re: [PATCH 11/18] fs: Introduce per-bucket inode hash locks

[Christoph Hellwig]

On Fri, Oct 08, 2010 at 10:49:15AM +0100, Al Viro wrote:
> >  	HFS_I(inode)->rsrc_inode = dir;
> >  	HFS_I(dir)->rsrc_inode = inode;
> >  	igrab(dir);
> > -	hlist_add_head(&inode->i_hash, &HFS_SB(dir->i_sb)->rsrc_inodes);
> > +	hlist_bl_add_head(&inode->i_hash, &HFS_SB(dir->i_sb)->rsrc_inodes);
> >  	mark_inode_dirty(inode);
> 
> Lovely.  What protects that list?  Same question for hfsplus...

Nothing.  It's also never actually read.  For hfsplus all that is fixed
in my hfsplus tree, but I'll still need to find a sucker to backport
all this to hfs.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/