Re: [PATCH] kvm: add oom notifier for virtio balloon

From: Balbir Singh
Date: Fri Oct 08 2010 - 09:12:38 EST


* Dave Young <hidave.darkstar@xxxxxxxxx> [2010-10-05 20:45:21]:

> Balloon could cause guest memory oom killing and panic.
>
> Add oom notify to leak some memory and retry fill balloon after 5 minutes.
>
> At the same time add a mutex to protect balloon operations
> because we need leak balloon in oom notifier and give back freed value.
>
> Thanks Anthony Liguori for his sugestion about inflate retrying.
> Sometimes it will cause endless inflate/oom/delay loop,
> so I think next step is to add an option to do noretry-when-oom balloon.
>
> Signed-off-by: Dave Young <hidave.darkstar@xxxxxxxxx>

Won't __GFP_NORETRY prevent OOM? Could you please describe how you
tested the patch?

--
Three Cheers,
Balbir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/