Re: [PATCH 0/2] HID: hidraw, fix two NULL pointer dereferences

[Antonio Ospite]

On Wed, 06 Oct 2010 12:09:07 +0200
Jiri Slaby <jirislaby@xxxxxxxxx> wrote:

> On 10/06/2010 12:01 PM, Antonio Ospite wrote:
> > On Tue, 05 Oct 2010 23:12:00 +0200
> > Jiri Slaby <jirislaby@xxxxxxxxx> wrote:
[...]
> >> Hi, please fix also the window in hidraw_release.
> >>
> > 
> > I am not sure I get what you mean, can you please add more details?
> 
> Sure. Look at the code:
> if (!hidraw_table[minor])
>         return -ENODEV;
> ...
> dev = hidraw_table[minor];
> if (!--dev->open) {
> ...
> 
> This is done without minors_lock, so you can easily have dev being NULL
> even though the first if.
>

Jiri (Slaby) I think it makes more sense if you send a patch about this
as it is you who has raised the issue.

Thanks,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

Attachment: pgp00000.pgp
Description: PGP signature