Re: [PATCH 2/2] pm_trace: Add sysfs attr for rechecking dev hash.

[James Hogan]

Hi Pavel,

On Sunday 10 October 2010 19:04:00 Pavel Machek wrote:
> Hi!
> 
> > If the device which fails to resume is part of a loadable kernel module
> > it won't be checked at startup against the magic number stored in the
> > RTC.
> > 
> > Add a read-only sysfs attribute /sys/power/pm_trace_dev_hash which
> > contains a list of newline separated devices (usually just the one)
> > which currently match the last magic number. This allows the device
> > which is failing to resume to be found after the modules are loaded
> > again.
> > 
> > --- a/Documentation/power/s2ram.txt
> > +++ b/Documentation/power/s2ram.txt
> > 
> > @@ -49,6 +49,13 @@ machine that doesn't boot) is:
> >     device (lspci and /sys/devices/pci* is your friend), and see if you
> >     can fix it, disable it, or trace into its resume function.
> > 
> > +   If no device matches the hash, it may be a device from a loadable
> > kernel +   module that is not loaded until after the hash is checked.
> > You can check +   the hash against the current devices again after more
> > modules are loaded +   using sysfs:
> > +
> > +	cat /sys/power/pm_trace_dev_hash
> > +
> 
> Yep, but exact semantics of that sysfs file should probably be linked
> in the sysfs documentation...
> 								Pavel

To clarify, do you mean I should link to Documentation/ABI/testing/sysfs-power 
from Documentation/power/s2ram.txt, or just make sure the syfs file is 
documented in Documentation/ABI/testing/sysfs-power (which is done in v2 of 
this patch)?

Thanks for taking a look
James
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/