Re: [PATCH] Define _addr_lsb in siginfo_t for mips and ia64

From: Tony Luck
Date: Mon Oct 11 2010 - 12:53:28 EST


On Fri, Oct 8, 2010 at 11:13 AM, Luck, Tony <tony.luck@xxxxxxxxx> wrote:
> ia64 has HAVE_ARCH_COPY_SIGINFO_TO_USER - so it doesn't see
> this build problem because the version of copy_siginfo_to_user()
> in kernel/signal.c isn't the one we use. So I don't think that
> we need this (unless someone has some plan to unify the
> ARCH specific version).

I take this back ... in next-20101011 the disease has spread:

fs/signalfd.c: In function ‘signalfd_copyinfo’:
fs/signalfd.c:109: error: ‘const struct <anonymous>’ has no member
named ‘_addr_lsb’
fs/signalfd.c:109: warning: type defaults to ‘int’ in declaration of ‘__pu_x’
fs/signalfd.c:109: error: ‘const struct <anonymous>’ has no member
named ‘_addr_lsb’

So today I have build problems :-(

A question about the naming/type of this new field. "lsb" sounds like
it might mean
"least significant byte (or perhaps bit)" ... why is the type "short"?

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/