Re: [PATCH] x86, setup: Check early serial console per string insteadof one char

[Yinghai Lu]

On 10/11/2010 11:19 AM, H. Peter Anvin wrote:
> On 10/11/2010 10:50 AM, Yinghai Lu wrote:
>>
>> Move out serial_putchar() calling out of putchar
>> Let puts() to call serial_putchar() directly.
>>
>> So only need to check early_serial_base per string.
>>
>> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
>>
> 
> This seems to add a bunch of code for zero benefit.  Testing a global
> variable is zero cost compared to either a BIOS call or poking a serial
> port.

some server have bios serial console redirection support, and bios int call could send char to screen and serial port.

in that case, take out serial_putchar from putchar could produce more readable print out from serial console

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/