Re: [tip:x86/urgent] x86, numa: For each node, register the memoryblocks actually used

[David Rientjes]

On Mon, 11 Oct 2010, tip-bot for Yinghai Lu wrote:

> Commit-ID:  e9aeb8fdb6b197b9b1e1c49717de892593bb811e
> Gitweb:     http://git.kernel.org/tip/e9aeb8fdb6b197b9b1e1c49717de892593bb811e
> Author:     Yinghai Lu <yinghai@xxxxxxxxxx>
> AuthorDate: Sun, 10 Oct 2010 19:52:15 -0700
> Committer:  H. Peter Anvin <hpa@xxxxxxxxxxxxxxx>
> CommitDate: Mon, 11 Oct 2010 13:46:34 -0700
> 
> x86, numa: For each node, register the memory blocks actually used
> 
> Russ reported SGI UV is broken recently. He said:
> 
> | The SRAT table shows that memory range is spread over two nodes.
> |
> | SRAT: Node 0 PXM 0 100000000-800000000
> | SRAT: Node 1 PXM 1 800000000-1000000000
> | SRAT: Node 0 PXM 0 1000000000-1080000000
> |
> |Previously, the kernel early_node_map[] would show three entries
> |with the proper node.
> |
> |[    0.000000]     0: 0x00100000 -> 0x00800000
> |[    0.000000]     1: 0x00800000 -> 0x01000000
> |[    0.000000]     0: 0x01000000 -> 0x01080000
> |
> |The problem is recent community kernel early_node_map[] shows
> |only two entries with the node 0 entry overlapping the node 1
> |entry.
> |
> |    0: 0x00100000 -> 0x01080000
> |    1: 0x00800000 -> 0x01000000
> 
> After looking at the changelog, Found out that it has been broken for a while by
> following commit
> 
> |commit 8716273caef7f55f39fe4fc6c69c5f9f197f41f1
> |Author: David Rientjes <rientjes@xxxxxxxxxx>
> |Date:   Fri Sep 25 15:20:04 2009 -0700
> |
> |    x86: Export srat physical topology
> 
> Before that commit, register_active_regions() is called for every SRAT memory
> entry right away.
> 
> Use nodememblk_range[] instead of nodes[] in order to make sure we
> capture the actual memory blocks registered with each node.  nodes[]
> contains an extended range which spans all memory regions associated
> with a node, but that does not mean that all the memory in between are
> included.
> 
> Reported-by: Russ Anderson <rja@xxxxxxx>
> Tested-by: Russ Anderson <rja@xxxxxxx>
> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
> LKML-Reference: <4CB27BDF.5000800@xxxxxxxxxx>
> Cc: David Rientjes <rientjes@xxxxxxxxxx>
> Cc: <stable@xxxxxxxxxx> 2.6.33 .34 .35 .36
> Signed-off-by: H. Peter Anvin <hpa@xxxxxxxxxxxxxxx>

Acked-by: David Rientjes <rientjes@xxxxxxxxxx>

Sorry I hadn't seen this thread earlier, I wasn't cc'd on it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/