Re: [PATCH v4] memcg: reduce lock time at move charge

From: Daisuke Nishimura
Date: Tue Oct 12 2010 - 02:26:26 EST


On Tue, 12 Oct 2010 14:48:01 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:

> On Tue, 12 Oct 2010 12:56:13 +0900
> Daisuke Nishimura <nishimura@xxxxxxxxxxxxxxxxx> wrote:
>
> > > +err_out:
> > > + for (; mt < info + num; mt++)
> > > + if (mt->type == MC_TARGET_PAGE) {
> > > + putback_lru_page(mt->val.page);
> > Is this putback_lru_page() necessary ?
> > is_target_pte_for_mc() doesn't isolate the page.
> >
> Ok, v4 here. tested failure path and success path.
>
Looks good to me.

Acked-by: Daisuke Nishimura <nishimura@xxxxxxxxxxxxxxxxx>

Thanks,
Daisuke Nishimura.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/