Re: [PATCH 2/5] secmark: make secmark object handling generic

[Jan Engelhardt]

On Tuesday 2010-10-12 19:45, Eric Paris wrote:
>> >> -	.target     = secmark_tg,
>> >> -	.targetsize = sizeof(struct xt_secmark_target_info),
>> >> -	.me         = THIS_MODULE,
>> >> +	.name		= "SECMARK",
>> >> +	.revision	= 0,
>> >> +	.family		= NFPROTO_UNSPEC,
>> >> +	.checkentry	= secmark_tg_check,
>> >> +	.destroy	= secmark_tg_destroy,
>> >> +	.target		= secmark_tg,
>> >> +	.targetsize	= sizeof(struct xt_secmark_target_info),
>> >> +	.me		= THIS_MODULE,
>> >> };
>> 
>> I think that we don't need that extra tab above.
>
>Are you saying that you prefer lots of spaces to get alignment rather
>than the single tab?

This discussion has been had before, and the technical result is that 
tab's do not align, they only indent logical levels on the left side. 
(Since people could have their editors set to display tabs in non-8-wide 
fashion to either cram more onto the screen, or widen if they need it 
for clarity. Unfortunately, developers don't do the aligning 
consistently and instead, like the common Microsoft joke about how 100 
developers to insert a lightbulb, just declare 8 spaces for a tab a 
standard when that isn't really the point of a tab.)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/