Re: [PATCH unfinished update] firewire: sbp2: parallelize login/inquiry,reconnect, and shutdown

From: Stefan Richter
Date: Tue Oct 12 2010 - 19:09:41 EST


Stefan Richter wrote:
>> Maybe I need ordered per-target workqueues.
>
> No, I actually need per-node ordering. This device, like my other one
> and apparently most ones on the market actually keep their SCSI logical
> units in separate FireWire units. Currently firewire-sbp2 is not aware
> that fw_unit instances reside on the same node.
>
> This is going to be tougher than I hoped. Maybe I need a driver-global
> Inquiry mutex. Or move the __scsi_add_device() out of sbp2_login() into
> another work which is scheduled to a "single-threaded" workqueue.

More extensive change but probably with simpler end result: Let sbp2_probe
and sbp2_update perform login/scsi_add_device/reconnect directly. sbp2_probe
and sbp2_update are serialized per node, but (since 2.6.36 with cmwq)
parallelized across nodes.
--
Stefan Richter
-=====-==-=- =-=- -==-=
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/