Re: [PATCH] ath5k: fix build break from "ath5k: Print out opmodein debugfs"

[Ben Greear]

On 10/12/2010 11:18 AM, John W. Linville wrote:
> On Tue, Oct 12, 2010 at 11:13:31AM -0700, Linus Torvalds wrote:
> > On Tue, Oct 12, 2010 at 7:53 AM, John W. Linville
> > <linville@xxxxxxxxxxxxx>  wrote:
> > > Please don't make me commit such an ugly patch...
> >
> >   Why don't you just create a dummy inline ath_opmode_to_string() that
> > returns NULL in the non-debug case? The compiler will make the
> > conditionals all go away, and it will end up being "UNKNOWN" which is
> > just what you want. No?
>
> Shhh!  Your messing-up my manipulative mind games! :-)

Looks like this was my bug, and I lost these emails in a folder
I don't read so often.

If you're not happy with the fixes posted, let me know and
I'll work on one.

Thanks,
Ben


--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc  http://www.candelatech.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/