Re: [PATCH net-next] net: allocate skbs on local node

From: Pekka Enberg
Date: Thu Oct 14 2010 - 02:23:00 EST


On Wed, 13 Oct 2010, Christoph Lameter wrote:
I was going to mention that as an idea, but I thought storing the metadata
for certain debugging features might differ from the two allocators so
substantially that it would be even more convoluted and difficult to
maintain?

We could have some callbacks to store allocator specific metadata?

On 10/14/10 1:41 AM, David Rientjes wrote:
It depends on whether we could share the same base for both slab (unified
allocator) and slub, which you snipped from your reply, that would make
this cleaner.

Argh. Why would we want to introduce something that's effectively a new allocator based on SLUB? If there's something controversial in the current patch series, lets just keep it out of mainline. A "rewrite" is the reason we're in this mess so lets not repeat the same mistake again!

Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/