Re: [PATCH v3 2/7] sched: accumulate per-cfs_rq cpu usage

[Peter Zijlstra]

On Tue, 2010-10-12 at 13:21 +0530, Bharata B Rao wrote:
> +static void account_cfs_rq_quota(struct cfs_rq *cfs_rq,
> +               unsigned long delta_exec)
> +{
> +       if (cfs_rq->quota_assigned == RUNTIME_INF)
> +               return;
> +
> +       cfs_rq->quota_used += delta_exec;
> +
> +       if (cfs_rq->quota_used < cfs_rq->quota_assigned)
> +               return;
> +
> +       cfs_rq->quota_assigned += tg_request_cfs_quota(cfs_rq->tg);
> +}

That looks iffy, quota_assigned is only ever incremented and can wrap.
Why not subtract delta_exec and replenish when <0? That keeps the
numbers small.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/