Re: [PATCH] bitops.h: Widen BIT macro to support 64-bit types

From: Borislav Petkov
Date: Thu Oct 14 2010 - 08:12:32 EST


From: Matthew Wilcox <matthew@xxxxxx>
Date: Thu, Oct 14, 2010 at 07:12:13AM -0400

> On Thu, Oct 14, 2010 at 12:58:55PM +0200, Borislav Petkov wrote:
> > #ifdef __KERNEL__
> > -#define BIT(nr) (1UL << (nr))
> > +#define BIT(nr) (U64_C(1) << (nr))
>
> Why not just use 1ULL instead?

Wanted to be __ASSEMBLY__ safe.

--
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/