Re: [patch] x86: allow ZONE_DMA to be configurable

From: Andrew Morton
Date: Thu Oct 14 2010 - 15:36:31 EST


On Thu, 14 Oct 2010 20:34:48 +0200
Ingo Molnar <mingo@xxxxxxx> wrote:

>
> * H. Peter Anvin <hpa@xxxxxxxxx> wrote:
>
> > On 10/14/2010 09:00 AM, Pekka Enberg wrote:
> >
> > >> CONFIG_EMBEDDED *is* "I am a user who (think I) know what I'm
> > >> doing". That is *what it is* and *all it is*.
> > >
> > > Yup. The naming is quite unfortunate, though. Can we change it to
> > > something else?
> >
> > Funny, this seems to come up repeatedly ;)
>
> I'd suggest to rename CONFIG_EMBEDDED=y to CONFIG_EXPERT=y, but i'd also
> suggest to rename all sub-config-options that depend on CONFIG_EXPERT to
> have a CONFIG_EXPERT_ prefix.
>
> So we'd have:
>
> CONFIG_EXPERT_CPU_SUP_INTEL=y
> CONFIG_EXPERT_MMAP_ALLOW_UNINITIALIZED=y
>
> etc.

yup. CONFIG_EMBEDDED didn't make a lot of sense even when we first did it.
I suppose CONFIG_EXPERT is OK, although everyone will select it because
they think they're experts ;) CONFIG_PROPELLORHEAD!

> That way all the enabled 'expert options' become easily visible in the
> .config file and they advertise themselves properly - it's also easily
> greppable. In the source code it also becomes self-documenting, it's
> obvious when a dependency is 'rare' or 'special' - it has a
> CONFIG_EXPERT_ prefix.
>
> Something for the KS i guess.

nah, just do it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/