Re: mmotm 2010-10-13-17-13 uploaded (leds)

[Randy Dunlap]

On 10/14/10 13:13, Johannes Berg wrote:
> On Thu, 2010-10-14 at 09:14 -0700, Randy Dunlap wrote:
> 
>>> Are there dependencies missing? I was under the impression that this
>>> shouldn't be happening. And what's the point in having triggers, but
>>> nothing to trigger...? How about the patch below?
>>
>> It seems to be due to net/mac80211/Kconfig:
>>
>> config MAC80211_LEDS
>> 	bool "Enable LED triggers"
>> 	depends on MAC80211
>> 	select NEW_LEDS
>> 	select LEDS_TRIGGERS
> 
> Ohh. Indeed, that should be easy to fix, make it depend on
> LEDS_TRIGGERS=y || LEDS_TRIGGERS=MAC80211 or so?

Yes.

>>> Reported-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>>> Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>
>>
>> The patch does not apply cleanly to mmotm, but it seems
>> like a good plan...
> 
> Hmm, ok, it was against the latest -rc or so. It'll have to wait a bit,
> I'm about to leave for a week. Sorry!

No problem.

later,
-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/