Re: [PATCH v2] slub: Drop slab lock for partial list handling

From: Christoph Lameter
Date: Fri Oct 15 2010 - 10:32:16 EST


On Thu, 14 Oct 2010, Pekka Enberg wrote:

> There's no need to hold 'page' slab lock for partial list handling functions. A
> page is bound to a node so 'page->lru' is always protected by n->list_lock.

Only if there are no races introduced by dropping the lock early.

The freelist may be changed after dropping the slab lock. The
partial list operation may then end up adding a slab that is empty or full
to the partia list.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/