Re: [PATCH resend] Add sc16is7x2 driver

[Manuel Stahl]

On 15.10.2010 16:27, Greg KH wrote:
> On Fri, Oct 15, 2010 at 09:24:34AM +0200, Manuel Stahl wrote:
> > On 14.10.2010 21:01, Greg KH wrote:
> > > On Thu, Oct 07, 2010 at 10:15:07AM +0200, Manuel Stahl wrote:
> > > > --- /dev/null
> > > > +++ b/include/linux/spi/sc16is7x2.h
> > > > @@ -0,0 +1,17 @@
> > > > +#ifndef LINUX_SPI_SC16IS752_H
> > > > +#define LINUX_SPI_SC16IS752_H
> > > > +
> > > > +#define SC16IS7X2_NR_GPIOS 8
> > > > +
> > > > +struct sc16is7x2_platform_data {
> > > > +	unsigned int	uartclk;
> > > > +	/* uart line number of the first channel */
> > > > +	unsigned	uart_base;
> > > > +	/* number assigned to the first GPIO */
> > > > +	unsigned	gpio_base;
> > > > +	char		*label;
> > > > +	/* list of GPIO names (array length = SC16IS7X2_NR_GPIOS) */
> > > > +	const char	*const *names;
> > > > +};
> > > > +
> > > > +#endif
> > >
> > > Why is this needed in a .h file?  What other .c file uses this define
> > > and structure?
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > The board setup code can pass information about the uart and gpio
> > enumeration.
>
> What "board setup code"?  I don't see that here in the patch anywhere.

SPI devices are generally set up for a specific hardware board. I.e. for 
some ARM boards there is setup code in 
linux/arch/arm/mach-at91/board-<xyz>.c

I use the sc16is7x2 for a board that is not yet in vanilla, so the board 
setup code is not included in the patch.

Regards,
--
Manuel Stahl
Fraunhofer-Institut IIS
Leistungsoptimierte Systeme

Nordostpark 93
D90411 Nürnberg
Telefon  +49 (0)911/58061-6419
Fax      +49 (0)911/58061-6398
E-Mail   manuel.stahl@xxxxxxxxxxxxxxxxx

http://www.iis.fraunhofer.de
http://www.smart-power.fraunhofer.de
begin:vcard
fn:Manuel Stahl
n:Stahl;Manuel
email;internet:manuel.stahl@xxxxxxxxxxxxxxxxx
tel;work:+49 911 58061-6419
x-mozilla-html:FALSE
version:2.1
end:vcard