Re: [PATCH 4/4] sched: force balancing on newidle balance if localgroup has capacity

[Nikhil Rao]

On Fri, Oct 15, 2010 at 5:08 AM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> On Wed, 2010-10-13 at 12:09 -0700, Nikhil Rao wrote:
>> @@ -2824,6 +2845,10 @@ find_busiest_group(struct sched_domain *sd, int
>> this_cpu,
>> Â Â Â Â if (!sds.busiest || sds.busiest_nr_running == 0)
>> Â Â Â Â Â Â Â Â goto out_balanced;
>>
>> + Â Â Â /* ÂSD_BALANCE_NEWIDLE trumps SMP nice when underutilized */
>> + Â Â Â if (idle == CPU_NEWLY_IDLE && check_utilization(&sds))
>> + Â Â Â Â Â Â Â goto force_balance;
>
>
> There's a large comment a few lines up from here that tries to explain
> all these funny reasons for not balancing, that wants updating too.
>

Will do.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/