Re: [PATCH v2.6.36-rc7] mac80211: cancel restart_work explicitlyinstead of depending on flush_scheduled_work()

From: John W. Linville
Date: Fri Oct 15 2010 - 15:30:22 EST


On Fri, Oct 15, 2010 at 06:58:44PM +0200, Christian Lamparter wrote:
> On Friday 15 October 2010 18:39:37 Tejun Heo wrote:
> > Hello,
>
> > >> - /*
> > >> - * For key todo, it'll be empty by now but the work
> > >> - * might still be scheduled.
> > >> - */
> > >> - flush_scheduled_work();
> > >
> > > oops, todo work no longer exists...
> > >
> > > Anyway, ACK.
> >
> > Are you going to route this through wireless tree? Shall I repost
> > with update patch description?
>
> wireless-testing/wireless-next has already such a patch:
> "mac80211: cancel restart_work in ieee80211_unregister_hw" (2010-08-25)
>
> <http://git.kernel.org/?p=linux/kernel/git/linville/wireless-next-2.6.git;a=commit;h=258086a48b766d12a500f98834654ffa927ca475>
>
> John, can you please push to 2.6.36-rc8?
> (I know, I am _late_, but I didn't know about any potential problem
> in the mainline?)

I don't see how either patch would merit inclusion in 2.6.36 at this point.

John
--
John W. Linville Someday the world will need a hero, and you
linville@xxxxxxxxxxxxx might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/