Re: [PATCH 8/9] jump label: Make arch_jump_label_text_poke_early()optional

[David Daney]

On 10/15/2010 02:08 PM, Steven Rostedt wrote:
> On Fri, 2010-10-15 at 23:06 +0200, Peter Zijlstra wrote:
> > On Fri, 2010-10-15 at 16:09 -0400, Steven Rostedt wrote:
> > > +
> > > +#ifdef HAVE_ARCH_JUMP_LABEL_TEXT_POKE_EARLY
> > >   extern void arch_jump_label_text_poke_early(jump_label_t addr);
> > > +#else
> > > +static inline void arch_jump_label_text_poke_early(jump_label_t addr) {}
> > > +#endif
> > > +
> >
> > How often is this called, do we really need to avoid that call? It looks
> > like init code.
>
> Yeah, that's a good point.
>
> What's the harm in doing a stub in the mips code here?

Really the SPARC code (and any architectures added in the future with a 
well defined optimal NOP) should be doing nothing here as well.

So I could turn the question around and ask:  How many empty definitions 
of this thing do you want in the tree?

I will defer to Steven.  If he wants to push the empty stubs into all 
the architectures, I will update the MIPS patch and he can remove/revert 
the 'jump label: Make arch_jump_label_text_poke_early() optional' patch.

Let me know which option you would prefer.

David Daney

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/