Re: [PATCH v2.6.36-rc7] isdn/eicon: don't call flush_scheduled_work()from diva_os_remove_soft_isr()

From: Armin Schindler
Date: Sat Oct 16 2010 - 08:42:53 EST


On Fri, 15 Oct 2010, Tejun Heo wrote:
diva doesn't use workqueue and there is no reason to flush the system
workqueue from diva_os_remove_soft_isr(). Remove it.

This is to prepare for the deprecation and removal of
flush_scheduled_work().

This is a leftover. Thanks.

Acked-by: Armin Schindler <armin@xxxxxxxxxx>

Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
---
drivers/isdn/hardware/eicon/divasmain.c | 2 --
1 file changed, 2 deletions(-)

Index: work/drivers/isdn/hardware/eicon/divasmain.c
===================================================================
--- work.orig/drivers/isdn/hardware/eicon/divasmain.c
+++ work/drivers/isdn/hardware/eicon/divasmain.c
@@ -15,7 +15,6 @@
#include <asm/uaccess.h>
#include <asm/io.h>
#include <linux/ioport.h>
-#include <linux/workqueue.h>
#include <linux/pci.h>
#include <linux/interrupt.h>
#include <linux/list.h>
@@ -546,7 +545,6 @@ void diva_os_remove_soft_isr(diva_os_sof
void *mem;

tasklet_kill(&pdpc->divas_task);
- flush_scheduled_work();
mem = psoft_isr->object;
psoft_isr->object = NULL;
diva_os_free(0, mem);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/