Re: [PATCH 17/19] fs: Reduce inode I_FREEING and factor inodedisposal

From: Dave Chinner
Date: Sun Oct 17 2010 - 19:39:31 EST


On Sun, Oct 17, 2010 at 06:05:19PM +1100, Nick Piggin wrote:
> On Sun, Oct 17, 2010 at 05:52:45PM +1100, Dave Chinner wrote:
> > > A really quick grep reveals cifs is using GlobalSMBSeslock inside i_lock
> > > too.
> >
> > I'm having a grep-fail day. Where is that one?
>
> Uh, inside one of the 6 places that i_lock is taken in cifs. The only
> non-trivial one, not surprisingly.

It's two function calls away from the use of i_lock, in a different file.
A quick grep on a warm, sunny Sunday afternoon between walking the
dog and heading down to the pub for a beer and dinner isn't going to
find that. :/

Anyway, this one looks fairly easy to fix as the code that locks
GlobalSMBSeslock is only called from this location. I'll code up a
patch to fix it.

Cheers,

Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/