Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

[Anand Gadiyar]

On 10/19/2010 9:22 PM, Greg KH wrote:
> On Tue, Oct 19, 2010 at 01:03:28PM +0300, Felipe Contreras wrote:
> > Add missing dependencies, and remove redundant ones, and select sensible
> > defaults.
> >
> > Signed-off-by: Felipe Contreras<felipe.contreras@xxxxxxxxx>
> > ---
> >   drivers/mfd/Kconfig        |    3 ++-
> >   drivers/regulator/Kconfig  |    1 +
> >   drivers/usb/gadget/Kconfig |    3 +--
> >   drivers/usb/musb/Kconfig   |    6 ++----
> >   drivers/usb/otg/Kconfig    |    2 ++
> >   5 files changed, 8 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index db51ea1..0bbaf01 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -156,6 +156,7 @@ config MENELAUS
> >   config TWL4030_CORE
> >   	bool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0 Support"
> >   	depends on I2C=y&&  GENERIC_HARDIRQS
> > +	default y if ARCH_OMAP3 || ARCH_OMAP4
>
> Sorry, but unless the driver is somehow required to keep the board from
> going up in a puff of smoke, a default should NEVER be y.
>
> Because of that, I can't take this patch.

This is the driver for the Power-management IC on the board. Without 
this IC being correctly configured, I'm guessing a lot of things will 
fail. Not so sure if anything will go up in smoke (sounds unlikely), or 
if the kernel will fail to boot - I'll check quickly - but for this one 
specific instance, I think it's reasonable to accept a default y.

Kevin/Tony can probably confirm.

Greg,

For other instances of unnecessary "default y", do you think they should 
be removed?

- Anand


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/