Re: [PATCH] POWER: Add gpio chager driver

From: Anton Vorontsov
Date: Thu Oct 21 2010 - 11:06:30 EST


On Thu, Oct 21, 2010 at 04:52:37PM +0200, Lars-Peter Clausen wrote:
[...]
> >> + gpio_charger->irq = gpio_to_irq(pdata->gpio);
> >> + if (gpio_charger->irq >= 0) {
> >
> > 0 isn't valid IRQ number. The check should be just 'if (gpio_charger->irq)'.
>
> While it is unlikely to be used for an gpio IRQ, as far as I know 0 is a valid IRQ
> number.

0 may be a valid HW IRQ, but not VIRQ.

http://www.mail-archive.com/linuxppc-dev@xxxxxxxxxxxxxxxx/msg22857.html

Thanks,

--
Anton Vorontsov
email: cbouatmailru@xxxxxxxxx
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/