Re: [PATCH net-next-2.6 v1] can: Topcliff: Update PCH_CAN driverto 2.6.35

[David Miller]

From: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
Date: Mon, 25 Oct 2010 00:05:25 +0200

> On 10/24/2010 11:43 PM, David Miller wrote:
>> From: Masayuki Ohtak <masa-korg@xxxxxxxxxxxxxxx>
>> Date: Fri, 15 Oct 2010 22:00:28 +0900
>> 
>>> CAN driver of Topcliff PCH
>>>
>>> Topcliff PCH is the platform controller hub that is going to be used in
>>> Intel's upcoming general embedded platform. All IO peripherals in
>>> Topcliff PCH are actually devices sitting on AMBA bus. 
>>> Topcliff PCH has CAN I/F. This driver enables CAN function.
>>>
>>> Signed-off-by: Masayuki Ohtake <masa-korg@xxxxxxxxxxxxxxx>
>> 
>> Applied, thanks.
> 
> IMHO this driver needs some improvements. There are some open points
> from Wolfgangs and my review. On the other side, it's a new driver and
> there's some time left before it hits mainline.

When people have more than a week to review and provide feedback,
and don't, I have zero sympathy especially this early in the
release cycle.

So if adding it to the tree is what I have to do to get you guys to
post your comments and suggest fixes, then that's what I am going to
(continue) to do. :-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/