Re: [PATCH 14/29] memstick: remove the memstick_set_rw_addr

[Alex Dubov]

--- On Fri, 22/10/10, Maxim Levitsky <maximlevitsky@xxxxxxxxx> wrote:

> From: Maxim Levitsky <maximlevitsky@xxxxxxxxx>
> Subject: [PATCH 14/29] memstick: remove the memstick_set_rw_addr
> To: "Alex Dubov" <oakad@xxxxxxxxx>
> Cc: "Andrew Morton" <akpm@xxxxxxxxxxxxxxxxxxxx>, "LKML" <linux-kernel@xxxxxxxxxxxxxxx>, "Maxim Levitsky" <maximlevitsky@xxxxxxxxx>
> Received: Friday, 22 October, 2010, 4:53 PM
> Remove this function, what was
> last user that did send the MS_TPC_SET_RW_REG_ADRS
> directly.
> 
> Just invalidate the register window, and next register
> read/write will send that tpc automaticly.
> 
> Signed-off-by: Maxim Levitsky <maximlevitsky@xxxxxxxxx>
> ---

How is an obscure invalidate_reg_window function is any better than
explicit set_rw_addr? Total number of calls to either of them is exactly
the same.

Sony state machine diagrams suggest that doing a precise set_rw_addr when
necessary is a good thing. The feature was originally conceived because
Sony intended to manufacture MSIO and hybrid devices, which might have very
large number of registers (hundreds). It was also supposed to help with
backward compatibility of devices, as well as with DRM functionality

We know, at this point of time, that Sony is sort of loosing the format
war, so MSIO devices these days are very hard to come by. However, some
hybrid (Transfer Jet) and DRM-secured devices still exist and it is wise
to retain functionality which can help to operate those (I don't have full
details on their operation, but it doesn't mean we should forget them
outright).



      
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/