Re: [PATCH] ACPI / Battery: Return -ENODATA for unknown values in get_property()

[Rafael J. Wysocki]

On Monday, October 25, 2010, Pavel Machek wrote:
> Hi!
> 
> > That's why I suggested to use -ENODATA. :-)
> > 
> > Still, if user space has problems with failing reads from the sysfs attributes,
> > it may be better to simply put -1 in there.  Patch is appended, please test.
> 
> I'd say that reporting -1 for unknown is ugly. You can have -1A
> current easily (charging at 1A), and I've seen machines reporting <0
> current -- when charging. Logical and well-defined.

I posted a patch fixing that in a different way (makng the battery driver return
-ENODEV instead of -ENODATA) in the meantime, which has been confirmed to work.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/